Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improving PR experience with comments #6

Open
wants to merge 85 commits into
base: main
Choose a base branch
from

Conversation

DE7924
Copy link

@DE7924 DE7924 commented Dec 4, 2024

feat: added post faliure comment github PR

feat: added post faliure comment github PR
@DE7924 DE7924 requested a review from a team as a code owner December 4, 2024 16:40
Copy link

github-actions bot commented Dec 4, 2024

Test Coverage Report

Code Coverage Report
File Statements Branches Functions Lines
src
98.5% 263/267 89.47% 17/19 80% 8/10 98.5% 263/267
src/components
81.48% 44/54 87.5% 7/8 50% 3/6 81.48% 44/54
src/components/accordion
57.89% 33/57 0% 0/1 0% 0/3 57.89% 33/57
src/components/action-menu
96.03% 97/101 83.33% 10/12 85.71% 6/7 96.03% 97/101
src/components/avatar
98.48% 65/66 100% 2/2 100% 2/2 98.48% 65/66
src/components/avatar-rail
81.08% 30/37 100% 0/0 0% 0/2 81.08% 30/37
src/components/badges/indicators
100% 76/76 84.61% 11/13 100% 5/5 100% 76/76
src/components/badges/label
76.19% 32/42 0% 0/1 0% 0/2 76.19% 32/42
src/components/badges/priority-pill
84.09% 37/44 0% 0/1 0% 0/1 84.09% 37/44
src/components/badges/status-label
65.57% 40/61 0% 0/1 0% 0/2 65.57% 40/61
src/components/badges/tag
97.77% 44/45 50% 2/4 100% 2/2 97.77% 44/45
src/components/badges/workcloud-indicator
56.25% 27/48 100% 3/3 50% 2/4 56.25% 27/48
src/components/bottom-sheets
100% 65/65 100% 13/13 100% 3/3 100% 65/65
src/components/breadcrumbs
90.12% 73/81 70% 7/10 75% 3/4 90.12% 73/81
src/components/breadcrumbs/breadcrumb-item
100% 33/33 50% 1/2 100% 1/1 100% 33/33
src/components/button
95.31% 122/128 73.33% 11/15 75% 6/8 95.31% 122/128
src/components/button-group
87.87% 29/33 0% 0/1 0% 0/2 87.87% 29/33
src/components/button-group/button-group-item
45.45% 35/77 0% 0/1 0% 0/4 45.45% 35/77
src/components/button/icon-button
100% 28/28 50% 1/2 100% 1/1 100% 28/28
src/components/card
93.54% 29/31 0% 0/1 0% 0/1 93.54% 29/31
src/components/card/card-body
91.3% 21/23 100% 0/0 0% 0/1 91.3% 21/23
src/components/card/card-footer
91.3% 21/23 100% 0/0 0% 0/1 91.3% 21/23
src/components/card/card-header
100% 42/42 100% 1/1 100% 1/1 100% 42/42
src/components/checkbox
100% 33/33 100% 2/2 100% 2/2 100% 33/33
src/components/chips/assist-chip
94.59% 35/37 50% 2/4 100% 2/2 94.59% 35/37
src/components/chips/base-chips
81.81% 9/11 100% 2/2 50% 1/2 81.81% 9/11
src/components/chips/filter-chip
86.66% 39/45 66.66% 4/6 66.66% 2/3 86.66% 39/45
src/components/chips/input-chip
100% 29/29 50% 1/2 100% 1/1 100% 29/29
src/components/chips/status-chip
85.18% 23/27 0% 0/1 0% 0/2 85.18% 23/27
src/components/dialog
95.68% 133/139 36.36% 4/11 57.14% 4/7 95.68% 133/139
src/components/dropdown
79.35% 123/155 78.26% 18/23 66.66% 6/9 79.35% 123/155
src/components/dropdown/dropdown-menu
90.95% 171/188 81.81% 27/33 87.5% 7/8 90.95% 171/188
src/components/dropdown/menu-item
86.66% 39/45 50% 1/2 50% 1/2 86.66% 39/45
src/components/fab
100% 76/76 93.33% 14/15 100% 5/5 100% 76/76
src/components/file-upload
60% 93/155 50% 2/4 22.22% 2/9 60% 93/155
src/components/global-header
100% 52/52 40% 2/5 100% 2/2 100% 52/52
src/components/grid-menu-item
100% 41/41 50% 2/4 100% 2/2 100% 41/41
src/components/icon
100% 40/40 90.9% 10/11 100% 3/3 100% 40/40
src/components/in-page-banner
95.77% 68/71 42.85% 3/7 100% 3/3 95.77% 68/71
src/components/list
86.66% 26/30 100% 0/0 0% 0/2 86.66% 26/30
src/components/list/list-item
100% 40/40 100% 1/1 100% 1/1 100% 40/40
src/components/navigation-bar
100% 30/30 100% 2/2 100% 2/2 100% 30/30
src/components/navigation-drawer
100% 62/62 66.66% 2/3 100% 2/2 100% 62/62
src/components/navigation-drawer/navigation-drawer-footer
82.95% 73/88 50% 2/4 50% 2/4 82.95% 73/88
src/components/navigation-drawer/navigation-drawer-header
56.25% 27/48 100% 0/0 0% 0/2 56.25% 27/48
src/components/navigation-drawer/navigation-drawer-item
100% 45/45 66.66% 2/3 100% 2/2 100% 45/45
src/components/navigation-drawer/navigation-drawer-sub-item
100% 38/38 66.66% 2/3 100% 2/2 100% 38/38
src/components/navigation-profile
100% 35/35 50% 1/2 100% 1/1 100% 35/35
src/components/navigation-rail
100% 74/74 60% 3/5 100% 3/3 100% 74/74
src/components/pagination
98.54% 135/137 92.3% 24/26 100% 7/7 98.54% 135/137
src/components/progress-indicators/progress-bar
92.64% 63/68 42.85% 3/7 100% 3/3 92.64% 63/68
src/components/progress-indicators/progress-circle
99.2% 125/126 85.71% 18/21 100% 7/7 99.2% 125/126
src/components/radio-button
100% 65/65 100% 10/10 100% 7/7 100% 65/65
src/components/search
82.4% 89/108 86.66% 13/15 80% 8/10 82.4% 89/108
src/components/segmented-control
93.75% 120/128 73.91% 17/23 100% 8/8 93.75% 120/128
src/components/slider
82.29% 265/322 89.18% 33/37 85.71% 18/21 82.29% 265/322
src/components/slider/range-selector
98.85% 172/174 96.42% 27/28 91.66% 11/12 98.85% 172/174
src/components/slider/slider-input-field
98.71% 154/156 91.66% 11/12 88.88% 8/9 98.71% 154/156
src/components/snackbar
97.77% 88/90 83.33% 10/12 100% 3/3 97.77% 88/90
src/components/stepper
100% 75/75 62.5% 5/8 100% 3/3 100% 75/75
src/components/stepper-input
100% 98/98 95.23% 20/21 100% 4/4 100% 98/98
src/components/switch
94.05% 95/101 90% 9/10 75% 3/4 94.05% 95/101
src/components/system-banner
66.12% 41/62 0% 0/1 0% 0/2 66.12% 41/62
src/components/tab-bar
92.85% 26/28 100% 0/0 0% 0/1 92.85% 26/28
src/components/tab-bar/tab-item
83.87% 26/31 0% 0/1 0% 0/2 83.87% 26/31
src/components/text-input
100% 147/147 95.83% 46/48 100% 10/10 100% 147/147
src/components/tooltip
71.05% 27/38 0% 0/1 0% 0/2 71.05% 27/38
src/components/top-appbar
100% 49/49 100% 7/7 100% 3/3 100% 49/49
src/components/upload-item
100% 67/67 88.88% 8/9 100% 4/4 100% 67/67
src/mixins
95.62% 699/731 100% 110/110 79.59% 39/49 95.62% 699/731
src/test
100% 148/148 100% 22/22 100% 14/14 100% 148/148
src/test/text-input
100% 55/55 100% 2/2 100% 1/1 100% 55/55

Copy link

github-actions bot commented Dec 4, 2024

Visit the preview URL for this PR (updated for commit 4cbce66):

https://zeta-web-main--pr-6-improve-pr-experience-en3vl2xt.web.app

(expires Fri, 27 Dec 2024 14:50:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: cc82fb52ba05c9ecc7f0b92ab81ac4a31b88d893

@ZebraDevs ZebraDevs deleted a comment from github-actions bot Dec 4, 2024
@ZebraDevs ZebraDevs deleted a comment from github-actions bot Dec 4, 2024
@ZebraDevs ZebraDevs deleted a comment from github-actions bot Dec 4, 2024
Copy link

github-actions bot commented Dec 5, 2024

PR Checks Complete

  • ✅ - Install Dependencies
  • ✅ - Custom Elements Manifest
  • ❌ - ESLint: 1 problem found
    See Details
    FileLineColumnMessage
    /home/runner/work/zeta-web/zeta-web/src/components/fab/fab.ts116'nothing' is defined but never used. Allowed unused vars must match /^_/u. [Warning/@typescript-eslint/no-unused-vars]
  • ✅ - Lit Analyzer
  • ✅ - Prettier
  • ✅ - Install PlayWright Browsers
  • ❌ - Testing
    See Details
    FileTest NameLineTypeMessage
    src/test/fab/fab.test.tsrenders a button with a label35AssertionErrorexpected null to exist
    src/test/fab/fab.test.tsrenders an extended fab54AssertionErrorexpected null to exist
    src/test/fab/fab.test.tsrenders a default fab63AssertionErrorexpected null to exist
  • ❌ - TSDoc
    See Details > @zebra-fed/[email protected] docs > npx typedoc --logLevel Warn

    �[96msrc/components/fab/fab.ts�[0m:�[93m1�[0m:�[93m16�[0m - �[91merror�[0m�[90m TS6133: �[0m'nothing' is declared but its value is never read.

    �[7m1�[0m import { html, nothing } from "lit";
    �[7m �[0m �[91m ~~~~~~~�[0m

    �[91m[error]�[0m Found 1 errors and 0 warnings

  • ✅ - Check for modified files
  • ✅ - Update changes in GitHub repository

@ZebraDevs ZebraDevs deleted a comment from github-actions bot Dec 20, 2024
github-actions and others added 28 commits December 20, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant